Flourish PHP Unframework
This is an archived copy of the forum for reference purposes

JSMin Algorithm

posted by mattsah 8 years ago

My understanding of the minification code in Flourish is that it is a clean slate implementation of the JSMin algorithm. I have previously run into the following issue: http://code.google.com/p/minify/issues/detail?id=144 -- it seems to be a bug or oversight in the algorithm itself. Just wondering if there would be any interest in making the actual improvement necessary to resolve this. There are two bugs mentioned in the thread, and it would seem nice, despite how poorly it may be as a programming practice to support this since technically it is valid.

So this issue is explicitly called out by Crockford at http://www.crockford.com/javascript/jsmin.html, so I wouldn't necessarily call it a bug or an oversight, just an edge case he determined was not worth handling.

If you open a ticket I will look into adding support for ++ +, - ++, - --, etc.

posted by wbond 8 years ago

This has been fixed in r1032.

posted by wbond 8 years ago