Ticket #362: PHP short tags in some php files

Reporter: Praym Type: defect Opened: 7 months ago Status: closed
Assigned to: wbond Priority: major Modified: 6 months ago Resolution: fixed

Hi Will,

I downloaded and installed the demo site. I had php short tags settings off in my php install and as a result found that the index page wont load. But when I enabled short tags it all worked.

Looks like some of the files in the library/site have <?php and some have <?.

What do you say about getting them all to a standard <?php styles?

- Praym


Attachments

History

Reply 12/24/09 16:20:35 changed by alexleeds

I just did a check, and none of them have PHP short tags. They are all <?php.

Reply 12/24/09 17:16:47 changed by Praym

Hi Alex,

Let me first assert that I have really liked this library. I sincerely appreciate the effort put in by Will and all associated with this project. I sincerely have best wishes for this library and I am going to use it in my next project.

The library might have all the <?php tags, but have a look in the NorthShoreWebGeeks? demo site. manage.php file has short tag. Please check the file provided in the flourish_demo_site_r718.zip

Also look at the code mentioned on this page for 'The manage page' : http://flourishlib.com/blog/FlourishDemoSite#TheManagePage

Here is how it is starting:



<?
include './inc/init.php';
fAuthorization::requireLoggedIn();
$action = fRequest::getValid(

I have not checked any other file. I reported the issue just by looking at this file and assuming that if it is there in any other file, it would be good to check all the files.



-Praym

Reply 12/29/09 15:13:05 changed by wbond

  • status changed from new to assigned.

I thought a while ago I had gone through and changed all of those to long PHP tags. I will update the zip to fix that in the next day or two.

Reply 01/25/10 20:57:41 changed by wbond

  • status changed from assigned to closed.
  • resolution set to fixed.

I've updated the demo site zip to r745 and removed the last of the short tags. Thanks!

Edit the Ticket



please register or log in to allow for editing your comment

Action